Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phone login support #2

Merged
merged 3 commits into from
Oct 22, 2018
Merged

phone login support #2

merged 3 commits into from
Oct 22, 2018

Conversation

ujwal-setlur
Copy link
Contributor

Hi I have added phone login support. This requires the ujwal:accounts-phone package. Would be great if this can be merged. Thanks!

@theodorDiaconu
Copy link
Contributor

This is so badass, sorry for seeing it this late. This requires also good docs and indented code. But super nice! I'm gonna take care of it if you don't find the time!

Talking about this:

+mutation createUserWithPhone {
+      createUserWithPhone (phone: "+11234567890", profile: {name: "A Phone User"}) {
+			success
+      }
+    }

@ujwal-setlur
Copy link
Contributor Author

@theodorDiaconu, great! I will try to clean up the code and docs this weekend.

@ujwal-setlur
Copy link
Contributor Author

I have updated the pull request and also resolved cult-of-coders/apollo#52

@ujwal-setlur
Copy link
Contributor Author

@theodorDiaconu, thoughts on merging this?

@theodorDiaconu theodorDiaconu merged commit a3a04d5 into cult-of-coders:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ujwal-setlur @theodorDiaconu